events: adding detail to DatagramDropped event #2438
Merged
+154
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Adds address and connection ID information to the on_datagram_dropped event.
NOTE: This is a breaking change if your application stores the
DatagramDroppedevents, as a named lifetime was added to the struct.Description of changes:
This change adds additional details (local/remote address, src/dst connection ID) to the
on_datagram_droppedevent, to assist with debugging.Call-outs:
This is technically a breaking change, as a named lifetime was added to the struct.
Testing:
Added an integration test that changes the port before the handshake is confirmed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.